Use stringToPDFString to sanitizing bad "Prefix" entries in Page Label dictionaries, and add more validation
#7782
Conversation
…bel dictionaries It seems that certain bad PDF generators can create badly encoded "Prefix" entries for Page Labels, one example being http://ukjewishfilm.org/wp-content/uploads/2015/09/Jewish-Film-Festival-Programme-ONLINE.pdf. Unfortunately I didn't come across such a PDF file while adding the API support for Page Labels, but with them now being used in the viewer I just found this issue. With this patch, we now display the Page Labels in the same way as Adobe Reader.
… the Page Labels are well formed
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7dd96ebb03a0393/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15949ed00403501/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15949ed00403501/output.txt Total script time: 2.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7dd96ebb03a0393/output.txt Total script time: 2.63 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6a75e91fcd58d6b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6a75e91fcd58d6b/output.txt Total script time: 2.61 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/906d05061851125/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/447c4dc95d8f6ba/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/906d05061851125/output.txt Total script time: 25.62 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/447c4dc95d8f6ba/output.txt Total script time: 38.00 mins
|
|
Looks good, thanks! |
…alidation Use `stringToPDFString` to sanitizing bad "Prefix" entries in Page Label dictionaries, and add more validation
Use
stringToPDFStringto sanitizing bad "Prefix" entries in Page Label dictionariesAdd a bit more validation to
Catalog_readPageLabels, to ensure that the Page Labels are well formed