Upstream the changes from bug 1345294 - nsIPrefBranch should have methods to get/set unicode strings #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods to get/set unicode strings Note that in order to not break compatibility for the Firefox addon, the preprocessor is used. Re: [bug 1345294](https://bugzilla.mozilla.org/show_bug.cgi?id=1345294) and also [this commit](https://hg.mozilla.org/mozilla-central/rev/5a8192a650e9).
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2369b80767c4f86/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2369b80767c4f86/output.txt Total script time: 2.18 mins Published |
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Upstream the changes from bug 1345294 - nsIPrefBranch should have methods to get/set unicode strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that in order to not break compatibility for the Firefox addon, the preprocessor is used.
Re: bug 1345294 and also this commit.
Edit: Slightly easier reviewing with https://github.com/mozilla/pdf.js/pull/8172/files?w=1.