Enable the object-shorthand ESLint rule in src/shared and src/display
#8332
Conversation
Please see http://eslint.org/docs/rules/object-shorthand. For the most part, these changes are of the search-and-replace kind, and the previously enabled `no-undef` rule should complement the tests in helping ensure that no stupid errors crept into to the patch.
Please see http://eslint.org/docs/rules/object-shorthand. For the most part, these changes are of the search-and-replace kind, and the previously enabled `no-undef` rule should complement the tests in helping ensure that no stupid errors crept into to the patch.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/be5c715e478a653/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e3cff00bdcf0623/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/e3cff00bdcf0623/output.txt Total script time: 23.59 mins
Image differences available at: http://54.215.176.217:8877/e3cff00bdcf0623/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/be5c715e478a653/output.txt Total script time: 32.17 mins
Image differences available at: http://107.21.233.14:8877/be5c715e478a653/reftest-analyzer.html#web=eq.log |
|
The test failures above are unrelated to this patch, please see issue #8334. |
|
Thank you for doing this! |
And thank you for reviewing this, and other PRs :-) |
…thand-src-shared-display Enable the `object-shorthand` ESLint rule in `src/shared` and `src/display`
Since we're using Babel, it's now possible for us to use the more compact object notation available in ES6 (see this MDN article).
Please see http://eslint.org/docs/rules/object-shorthand; this is one of the rules mentioned in issue #7957.
Note: I initially created one big patch for this change, see master...Snuffleupagus:eslint-object-shorthand, but after looking at the diff I quickly realized that it was too big and I don't think anyone would want to review that. Hence I've decided to split it up into more manageable chunks instead.