Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code in the web/ folder to use async/await #9995

Merged
merged 6 commits into from
Sep 8, 2018
Merged

Refactor code in the web/ folder to use async/await #9995

merged 6 commits into from
Sep 8, 2018

Commits on Sep 3, 2018

  1. Refactor the IL10n implementations to utilize async methods rathe… 

    …r than manually returning `Promise`s

This changes the methods signatures of `GenericL10n`, `MozL10n`, and `NullL10n`.
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    b0fa02e View commit details
    Browse the repository at this point in the history

  2. Refactor the OverlayManager to utilize async methods rather than … 

    …manually returning `Promise`s
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    64e70fc View commit details
    Browse the repository at this point in the history

  3. Refactor the Preferences classes to utilize async methods rather … 

    …than manually returning `Promise`s
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    233b327 View commit details
    Browse the repository at this point in the history

  4. Refactor the ViewHistory to utilize async methods rather than man… 

    …ually returning `Promise`s
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    a60963f View commit details
    Browse the repository at this point in the history

  5. Refactor a number of methods in PDFViewerApplication to be async … 

    …rather than manually returning `Promise`s

*Ignoring whitespace changes is probably necessary, in order for the diff to be readable.*
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    3eba7ea View commit details
    Browse the repository at this point in the history

  6. Utilize async/await in PDFViewerApplication.load to reduce the … 

    …number of Promises and temporary variables necessary when setting the initial document location
    @Snuffleupagus
    Snuffleupagus committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    1bdfdd0 View commit details
    Browse the repository at this point in the history