/sign_in metric counted twice if user redirects to primary #3970

shane-tomlinson · 2013-10-10T16:21:29Z

With #3939, we have the ability to send kpiggybank the number of users who see the /sign_in dialog directly from the backend. There is a problem, users who redirect to a primary IdP are counted twice, the first time when they first open the dialog, the second time when they return to from the IdP.

…ticating with their primary. * Instead of using the #AUTH_RETURN* hash, use ?AUTH_RETURN*, which is sent to the backend and can be used to avoid double count. * /sign_in?AUTH_RETURN logs an `idp.auth_return` message * /sign_in?AUTH_RETURN_CANCEL logs an `idp.auth_cancel` message * Update tests. fixes #3970

ghost assigned shane-tomlinson Oct 10, 2013

shane-tomlinson mentioned this issue Oct 10, 2013

Avoid double-counting the /sign_in page when users return from authenticating with their primary. #3971

Merged

jaredhirsch closed this as completed in #3971 Oct 17, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

/sign_in metric counted twice if user redirects to primary #3970

/sign_in metric counted twice if user redirects to primary #3970

shane-tomlinson commented Oct 10, 2013

/sign_in metric counted twice if user redirects to primary #3970

/sign_in metric counted twice if user redirects to primary #3970

Comments

shane-tomlinson commented Oct 10, 2013