Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug 1603610 - Enable users to leave comments on translations #1524

Merged
merged 58 commits into from
Jan 24, 2020
Merged

Fix Bug 1603610 - Enable users to leave comments on translations #1524

merged 58 commits into from
Jan 24, 2020

Commits on Dec 31, 2019

  1. Initial setup of model for translation comments

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    af6fcef View commit details
    Browse the repository at this point in the history

  2. Made updates to and migrated Comment model

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    8cc1297 View commit details
    Browse the repository at this point in the history

  3. Send comment info to the frontend

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    1d3885a View commit details
    Browse the repository at this point in the history

  4. Refactoring

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    7f72c2b View commit details
    Browse the repository at this point in the history

  5. Initial steps to render comments on frontend

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    7cb311a View commit details
    Browse the repository at this point in the history

  6. Requested revisions

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    22e3cce View commit details
    Browse the repository at this point in the history

  7. Serialize comments and initial work on Comments component

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    0efd8f0 View commit details
    Browse the repository at this point in the history

  8. Refactored to add Comment and AddComment components

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    7cdbc07 View commit details
    Browse the repository at this point in the history

  9. Refactoring of comment components

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    476afcc View commit details
    Browse the repository at this point in the history

  10. Requested refactoring

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    ebf1d67 View commit details
    Browse the repository at this point in the history

  11. Fixed linting errors

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    3df52ab View commit details
    Browse the repository at this point in the history

  12. Refactoring and requested changes

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    1fcc776 View commit details
    Browse the repository at this point in the history

  13. Added function to rename keys in getHistory 

    :wq
    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    a6c3939 View commit details
    Browse the repository at this point in the history

  14. Added initial tests for Comments and CommentsList

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    ab6cf20 View commit details
    Browse the repository at this point in the history

  15. Revision of camelCase conversion and refactoring

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    7f62e1e View commit details
    Browse the repository at this point in the history

  16. Added typing to camelCase argument

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    ac452f5 View commit details
    Browse the repository at this point in the history

  17. Initial styling and requested revisions

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    b9fa253 View commit details
    Browse the repository at this point in the history

  18. Corrected localization and refactored

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    31d9559 View commit details
    Browse the repository at this point in the history

  19. Readded code lost during rebase

    @abowler2
    abowler2 committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    bf863cc View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Initial set up for delete and share buttons

    @abowler2
    abowler2 committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    917df09 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Changed classnames for comment and comment list and refactored

    @abowler2
    abowler2 committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    9c3c2af View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Added ability to verify delete comment permissions and function to de… 

    …lete comment
    @abowler2
    abowler2 committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    70aaf6e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Added tests to Comment test file

    @abowler2
    abowler2 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    c6fa2a7 View commit details
    Browse the repository at this point in the history

  2. Updated test

    @abowler2
    abowler2 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    9deeb20 View commit details
    Browse the repository at this point in the history

  3. Deleted unneeded migrations

    @abowler2
    abowler2 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    0cc6b5d View commit details
    Browse the repository at this point in the history

  4. Added comment_deleted to action log

    @abowler2
    abowler2 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    3ac721e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Initial work for Add Comment

    @abowler2
    abowler2 committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    2c2923a View commit details
    Browse the repository at this point in the history

  2. Renamed canReview, added api/comment, added translation to del commen… 

    …t action log
    @abowler2
    abowler2 committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    cb62abe View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Removed unneeded check in action log, added initial add comment function

    @abowler2
    abowler2 committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    654b5d5 View commit details
    Browse the repository at this point in the history

  2. Corrected functions to camelCase

    @abowler2
    abowler2 committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    528edef View commit details
    Browse the repository at this point in the history

  3. Minor refactor for typing

    @abowler2
    abowler2 committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    60898f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Added ability to save comment to DB

    @abowler2
    abowler2 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b3ea3b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Initial work to set button for toggling comments panel

    @abowler2
    abowler2 committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    902de9d View commit details
    Browse the repository at this point in the history

  2. Fixed broken tranlation test

    @abowler2
    abowler2 committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    8762a10 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Added check for null value and AddComment test

    @abowler2
    abowler2 committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    2e34f21 View commit details
    Browse the repository at this point in the history

  2. Added localized title and refactored

    @abowler2
    abowler2 committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    bc7656b View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Requested edits

    @abowler2
    abowler2 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    eb2f579 View commit details
    Browse the repository at this point in the history

  2. Made changes to localization for comment button

    @abowler2
    abowler2 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    3383171 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Requested changes, refactored title in UserAvatar

    @abowler2
    abowler2 committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    cc254a3 View commit details
    Browse the repository at this point in the history

  2. Removed the Delete Comment functionality

    @abowler2
    abowler2 committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    71b9288 View commit details
    Browse the repository at this point in the history

  3. Added new test for AddComment

    @abowler2
    abowler2 committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    0260b78 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. Break comment css into individual files

    @abowler2
    abowler2 committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    633ad4a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. Changed input to textarea for AddComment

    @abowler2
    abowler2 committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    6d5ad27 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Fixed spacing issues

    @abowler2
    abowler2 committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    b988f38 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Updated comments button settings, fixed collapsing comments, fixed te… 

    …st errors
    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    95c92f6 View commit details
    Browse the repository at this point in the history

  2. Hid comment button when no comments and not authenticated

    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    4e2e1c4 View commit details
    Browse the repository at this point in the history

  3. Updated permissions for comments

    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    62cca2b View commit details
    Browse the repository at this point in the history

  4. Made change to allow tests to pass

    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    58e5975 View commit details
    Browse the repository at this point in the history

  5. Changed the changes and fixed the test

    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    e1bf8e6 View commit details
    Browse the repository at this point in the history

  6. updated test

    @abowler2
    abowler2 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    95687ee View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Applied CSS patch

    @abowler2
    abowler2 committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    8adcef8 View commit details
    Browse the repository at this point in the history

  2. Additional CSS changes

    @abowler2
    abowler2 committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    9e56237 View commit details
    Browse the repository at this point in the history

  3. Fixed error with className

    @abowler2
    abowler2 committed Jan 22, 2020
    1 Configuration menu
    Copy the full SHA
    a7a13a7 View commit details
    Browse the repository at this point in the history

  4. Added font-weight to comments

    @abowler2
    abowler2 committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    ad32c94 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Fixed localization and syntax issues. Made needed migrations

    @abowler2
    abowler2 committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    9230e0c View commit details
    Browse the repository at this point in the history

  2. Refactored comment button

    @abowler2
    abowler2 committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    137eeec View commit details
    Browse the repository at this point in the history

  3. Requested changes to Comment toggle

    @abowler2
    abowler2 committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    1bccc01 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Disabled comments until team comments complete

    @abowler2
    abowler2 committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    6ad244f View commit details
    Browse the repository at this point in the history