Bug 1459440: Support Translate Toolkit checks for FTL strings #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the event payload from the <button> onClick handler from being inadvertently passed as the `ignoreWarnings` parameter to `sendTranslation`
Specifically, this implements the approach suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1459440#c1
|
Just a heads up, Prettier formatting has been merged to master, causing conflict on this branch. Please rebase and fix the conflicts as soon as you can, to avoid potentially more conflicts later on. Thank you. |
|
Sorry for the lack of response here. I don't think this is the right approach, so I'm going to close this one out. I don't know if what the right approach would be, but also, we should integrate less tightly with tt in general. I had this as an open question in the bug, but that was mostly me being polite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this implements the approach suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1459440#c1