Change name to Price Tracker

[biancadanforth]

@javaun , @chuckharmston Requesting your approval on the following noteworthy items:

• Leave the existing telemetry event category unchanged, 'extension.price_wise' for continuity.
• Remove the Feedback survey
• Alternatives (feedback form):
  • Teon updates the URL/survey page and we update it here in the extension.
  • We leave the survey and UI as-is
• Change the privacy policy URL to https://addons.mozilla.org/en-US/firefox/addon/price-tracker/privacy/. This requires changing the AMO URL to https://addons.mozilla.org/en-US/firefox/addon/price-tracker, which does not redirect from https://addons.mozilla.org/en-US/firefox/addon/price-wise .

---

Find and replace all instances of "Price Wise", "price-wise" and "price_wise" (case insensitive) with the following exceptions:

• The telemetry event category, 'extension.price_wise' for continuity.
• The survey URLs (for feedback linked to in the popup and the now flagged off UR study).

Note: Updating the name of the project in package.json and calling npm install also triggered adding an additional optional key in package-lock.json for some devDeps.

[clouserw]

I think it looks fine, but Chuck will be a better reviewer than me for this code so flagging him

[biancadanforth]

@javaun , @chuckharmston : In light of the urgency of this change request from Mika, I would ask that you please let me know by the end of the day tomorrow if at all possible (Wednesday, 3/20); otherwise my plan will be to:

• Leave the telemetry category as-is 'extension.price_wise'
• Remove the survey URL/UI entirely (I was considering finding a QA resource for this, but the change is small enough, that I think another engineer besides myself looking at it is fine, and that's consistent with the process used to remove the UR Study recruitment UI and add the Privacy Policy page on first run)
• Leave the privacy policy URL as-is (and thus keep the original AMO URL from which it is derived, https://addons.mozilla.org/en-US/firefox/addon/price-wise)

[chuckharmston]

My thoughts:

• It would certainly be desirable to leave the telemetry event category. I'll check with Mika to make sure that's okay. Mika is fine with this. Let's leave it as is.
• Let's remove the survey; it's not particularly useful if nobody is actively maintaining.
• As long as the link from the add-on works, I see no issues with changing the privacy policy link.

Thanks for handling this, Bianca!

[chuckharmston]

Filed mozilla/testpilot#4045 to make sure the Test Pilot site gets updated. @clouserw, can you make sure somebody is able to work on that?

[biancadanforth]

Thanks @chuckharmston for the quick feedback! Just one clarification for you:

As long as the link from the add-on works, I see no issues with changing the privacy policy link.

Just to confirm, since the privacy policy page's URL is based on the extension's AMO page URL, you would rather we update the AMO page URL from https://addons.mozilla.org/en-US/firefox/addon/price-wise/ to https://addons.mozilla.org/en-US/firefox/addon/price-tracker/ ? Per jorgev, it is not possible to redirect from the former to the latter.

[chuckharmston]

Yeah, that seems like the sort of thing that is necessary for us to do. Since this is effectively a dormant project, I'm not too concerned about the consequences of the URL change, especially since there's still a link on Test Pilot's site that can be changed.

[biancadanforth]

Got an AMO pre-review approval over e-mail from @wagnerand , so going to merge.

Also: thanks rhelmer!

[pdehaan]

Any ETA on when the add-on will be published at https://addons.mozilla.org/en-US/firefox/addon/price-tracker/?

[marniepw]

@pdehaan it's been submitted to AMO for review. Fingers crossed...

[biancadanforth]

It was published about an hour ago.

[pdehaan]

Filed mozilla/testpilot#4045 to make sure the Test Pilot site gets updated. @clouserw, can you make sure somebody is able to work on that?

This should be in production now, per mozilla/testpilot#4045 (comment)