Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require unique channel names #282

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Require unique channel names #282

merged 3 commits into from
Mar 16, 2021

Conversation

fbertsch
Copy link
Contributor

@fbertsch fbertsch commented Mar 16, 2021 •
edited
Loading

Fixes #281

@fbertsch fbertsch requested a review from relud March 16, 2021 14:12
@fbertsch
Copy link
Contributor Author

Confirmed this works on:

  • Multiple channels with no names
  • Multiple channels with the same name
  • Deprecated unique names (e.g. Fenix)

relud
relud approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@relud relud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

probe_scraper/check_repositories.py Outdated Show resolved Hide resolved
fbertsch and others added 2 commits March 16, 2021 12:05
@fbertsch @relud
Update probe_scraper/check_repositories.py
788e75e 
Co-authored-by: Daniel Thorn <dthorn@mozilla.com>
@fbertsch
Run black
ed202dd
@fbertsch fbertsch merged commit 70a2efb into mozilla:master Mar 16, 2021
@fbertsch fbertsch deleted the unique_channels branch March 16, 2021 16:22
@fbertsch fbertsch mentioned this pull request Apr 13, 2021
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relud relud relud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require unique non-deprecated channel names
2 participants
@fbertsch @relud