Switch mozillavpn_backend_cirrus to use nimbus-cirrus dependency (bug 1867770)
#708
Conversation
sean-rose
requested review from
chutten,
akkomar,
whd,
mikaeld,
Dexterp37,
badboy and
travis79
as code owners
| @@ -968,16 +968,15 @@ applications: | |||
| canonical_app_name: Mozilla VPN Cirrus Sidecar | |||
| app_description: | | |||
| The sidecar Cirrus container for the Mozilla VPN server | |||
| url: https://github.com/mozilla/experimenter | |||
| url: https://github.com/mozilla-services/guardian-website | |||
There was a problem hiding this comment.
That repo doesn't exist (or is not public). probe-scraper will fail on that. Should this be just https://github.com/mozilla-mobile/mozilla-vpn-client ?
There was a problem hiding this comment.
The repo exists but is restricted. Listing the VPN client repo wouldn't be appropriate since this is for the VPN server.
It seems like we might be able to sidestep the Git auth issue for now by having probe-scraper not try to scrape repos with no metrics/ping/tag files configured, so I've pushed a commit to do that, but let me know if that won't actually work for some reason.
sean-rose
force-pushed
the
bug-1867770-vpn-cirrus-dependency
branch
from
1b0aacd
to
e9765b2
Compare
| if not ( | ||
| repo_info.metrics_file_paths | ||
| or repo_info.ping_file_paths | ||
| or repo_info.tag_file_paths | ||
| ): | ||
| print( | ||
| f"Skipping commits for repository {repo_info.name}" | ||
| " because it has no metrics/ping/tag files." | ||
| ) | ||
| continue |
There was a problem hiding this comment.
This would currently skip the following 6 repos: engine-gecko, engine-gecko-beta, engine-gecko-nightly, lockwise-ios, mozillavpn-backend-cirrus, monitor-cirrus
There was a problem hiding this comment.
I guess that should be fine indeed.
Bug 1867770: Enable new Glean App
mozillavpn_cirrusThere should be no functional change, this just makes it clearer what's happening and avoids duplicating the Cirrus metrics/ping files config for VPN.