-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch mozillavpn_backend_cirrus
to use nimbus-cirrus
dependency (bug 1867770)
#708
Conversation
@@ -968,16 +968,15 @@ applications: | |||
canonical_app_name: Mozilla VPN Cirrus Sidecar | |||
app_description: | | |||
The sidecar Cirrus container for the Mozilla VPN server | |||
url: https://github.com/mozilla/experimenter | |||
url: https://github.com/mozilla-services/guardian-website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That repo doesn't exist (or is not public). probe-scraper will fail on that. Should this be just https://github.com/mozilla-mobile/mozilla-vpn-client ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo exists but is restricted. Listing the VPN client repo wouldn't be appropriate since this is for the VPN server.
It seems like we might be able to sidestep the Git auth issue for now by having probe-scraper not try to scrape repos with no metrics/ping/tag files configured, so I've pushed a commit to do that, but let me know if that won't actually work for some reason.
1b0aacd
to
e9765b2
Compare
if not ( | ||
repo_info.metrics_file_paths | ||
or repo_info.ping_file_paths | ||
or repo_info.tag_file_paths | ||
): | ||
print( | ||
f"Skipping commits for repository {repo_info.name}" | ||
" because it has no metrics/ping/tag files." | ||
) | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would currently skip the following 6 repos: engine-gecko
, engine-gecko-beta
, engine-gecko-nightly
, lockwise-ios
, mozillavpn-backend-cirrus
, monitor-cirrus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that should be fine indeed.
Bug 1867770: Enable new Glean App
mozillavpn_cirrus
There should be no functional change, this just makes it clearer what's happening and avoids duplicating the Cirrus metrics/ping files config for VPN.