Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate JS tests to jasmine-browser-runner #899

Closed
alexgibson opened this issue Oct 16, 2023 · 3 comments
Closed

Migrate JS tests to jasmine-browser-runner #899

alexgibson opened this issue Oct 16, 2023 · 3 comments
Assignees
@alexgibson

Comments

@alexgibson
Copy link
Member

See mozilla/bedrock#13423 for details.

TL:DR is karma is no longer maintained. We should migrate the Protocol tests to jasmine-browser-runner like we are doing for bedrock.
@alexgibson
Copy link
Member Author

It would also be nice to add Chrome to the browsers that run Protocol's tests in CI

@reemhamz reemhamz self-assigned this Apr 3, 2024
@alexgibson
Copy link
Member Author

@reemhamz are you still working on this one? If not, I can probably find time to get this one knocked out soon

@reemhamz
Copy link
Contributor

reemhamz commented Jun 17, 2024 •
edited
Loading

@alexgibson Ah yup I definitely haven't started this yet and have other things I need to work on for Protocol that are higher on my list, so feel free to go ahead with this one 👍🏼

@reemhamz reemhamz removed their assignment Jun 17, 2024
@alexgibson alexgibson self-assigned this Jun 21, 2024
alexgibson added a commit to alexgibson/protocol that referenced this issue Jun 21, 2024
@alexgibson
Migrate JS tests from Karma to Jasmine (Fixes mozilla#899)
9b5c01b
@alexgibson alexgibson mentioned this issue Jun 21, 2024
Merged
2 tasks
alexgibson added a commit to alexgibson/protocol that referenced this issue Jun 21, 2024
@alexgibson
Migrate JS tests from Karma to Jasmine (Fixes mozilla#899)
b04217b
alexgibson added a commit to alexgibson/protocol that referenced this issue Jun 21, 2024
@alexgibson
Migrate JS tests from Karma to Jasmine (Fixes mozilla#899)
44faa88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgibson alexgibson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexgibson @reemhamz