This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Addressing early review comments from Marcos. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,13 +22,13 @@ | |||
| return this.bottom - this.top; | |||
| }, | |||
| set width(v) { | |||
| this.right = this.left + v; | |||
| this.right = this.left + Number(v); | |||
There was a problem hiding this comment.
How about:
var num = Number.parseInt(v, 10);
Number.isNaN(num){
return;
}
this.right = this.left + num;There was a problem hiding this comment.
I wonder if we should have a generic type enforcement for Rect that throws if any of the values is NaN. Also, there is already a Rect class on the Window object it seems (that is different from this one).
There was a problem hiding this comment.
I'll make the change in your first comment and file an issue for generic type enforcement and changing the name of Rect to something else. How does that sound?
emtwo
force-pushed
the
emtwo/address-comments
branch
from
5899df0
to
f2db986
Compare
|
r+ |
emtwo
pushed a commit
that referenced
this pull request
Aug 27, 2015
Addressing early review comments from Marcos.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.