Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'safe mode' to master, do a major version bump #178

Merged
merged 68 commits into from
Jul 21, 2020
Merged

Conversation

victorporof
Copy link
Contributor

I think we're now ready for this.

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Safe mode arena allocation for databases
Cow snapshots instead of always cloning
Allow safe mode environment managers
Prevent needless key/value copies in database methods
…this method expects for params

Signed-off-by: Victor Porof <victor.porof@gmail.com>
…anywhere

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
…invalid databases

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
…rror

Signed-off-by: Victor Porof <victor.porof@gmail.com>
@victorporof
Copy link
Contributor Author

victorporof commented Nov 21, 2019

oh, i mean this one https://docs.rs/rkv/0.10.2/rkv/

@ncloudioj Doesn't that happen automatically when pushing to crates.io?

@victorporof
Copy link
Contributor Author

Oh I see what you mean, crate documentation in lib (and other files) is outdated.

victorporof and others added 11 commits November 22, 2019 10:27
…te` operations

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
…tabaseCorrupted`

Signed-off-by: Victor Porof <victor.porof@gmail.com>
…sers not to worry about which backend they're using

Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Opening should fail when read transactions exist for `open` and `create` operations
Make backend-related documentation easier to understand
Move tests to the `tests` directory to allow vendoring into m-c
@rnewman
Copy link
Contributor

rnewman commented Mar 7, 2020

@victorporof is there something still outstanding before this can be rebased and merged? I want to know before I have to do a bunch of PRs twice, once for master that will go to crates.io, and once for safe-mode

@victorporof
Copy link
Contributor Author

@rnewman The only thing remaining IIRC is to update the crate documentation. No other blockers, and I'm happy to get this landed.

Signed-off-by: Victor <victor.porof@gmail.com>
@victorporof victorporof mentioned this pull request Mar 10, 2020
@rnewman
Copy link
Contributor

rnewman commented Mar 30, 2020

@victorporof when I check this out and build it locally, I get 47 build errors like this:

error[E0432]: unresolved import `super::DatabaseFlagsImpl`
  --> src/backend/impl_safe/database.rs:18:5
   |
18 | use super::DatabaseFlagsImpl;
   |     ^^^^^^^-----------------
   |     |      |
   |     |      help: a similar name exists in the module: `DatabaseImpl`
   |     no `DatabaseFlagsImpl` in `backend::impl_safe`

What's up?

@victorporof
Copy link
Contributor Author

Sorry this slipped off my radar, will try to land asap.

@victorporof
Copy link
Contributor Author

victorporof commented Jul 20, 2020

@rnewman This builds just fine for me locally on latest stable and nightly. I'm not sure what's up in your case, are you still running into this?

@victorporof victorporof force-pushed the safe-mode branch 3 times, most recently from 8e7fc6b to 731e0cc Compare July 20, 2020 18:45
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Signed-off-by: Victor Porof <victor.porof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants