Migrate from Travis CI to GitHub Actions #220
Conversation
Boo. |
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1730873 says we don't want actions-rs. action-rs/cargo is not strictly needed, but not sure how to ditch action-rs/toolchain cleanly. |
| @@ -30,7 +30,7 @@ with-fuzzer-no-link = ["lmdb-rkv/with-fuzzer-no-link"] | |||
| [dependencies] | |||
| arrayref = "0.3" | |||
| bincode = "1.0" | |||
| bitflags = "1.1" | |||
| bitflags = "~1.2" | |||
There was a problem hiding this comment.
1.3 causes build failure on Rust 1.45.0. Maybe okay to bump the minimum supported version, but not here.
(Not sure 1.45.0 is even intended to be minimum supported version, there's no documentation for that 🤔)
There was a problem hiding this comment.
MSRV can probably be lifted, we just need to stay in sync with what m-c requires: https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
| # that we depend upon. When updating, pick a suitable nightly version | ||
| # from https://rust-lang.github.io/rustup-components-history/ | ||
| # See .rustfmt.toml for the list of unstable features. | ||
| KNOWN_TO_HAVE_RUSTFMT: nightly-2020-07-12 |
There was a problem hiding this comment.
Pinning to the existing old version from .travis.yml for now since newer version causes quite a lot of dead code warnings which I don't feel comfortable to fix here. (#221 for the trivial ones)
| @@ -30,7 +30,7 @@ with-fuzzer-no-link = ["lmdb-rkv/with-fuzzer-no-link"] | |||
| [dependencies] | |||
| arrayref = "0.3" | |||
| bincode = "1.0" | |||
| bitflags = "1.1" | |||
| bitflags = "~1.2" | |||
There was a problem hiding this comment.
MSRV can probably be lifted, we just need to stay in sync with what m-c requires: https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
Closes #213, closes #218