Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to Rust 1.58.0 #225

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Bump MSRV to Rust 1.58.0 #225

merged 1 commit into from
Aug 12, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 12, 2022

No description provided.

@badboy badboy requested a review from saschanaz August 12, 2022 16:42
Copy link
Collaborator

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it might be a good chance to replace .panic("{}", e) to .panic_any(e). Clippy suggested the latter but it caused errors in #221 on the old version. How about it?

@badboy
Copy link
Member Author

badboy commented Aug 12, 2022

Approving, but it might be a good chance to replace .panic("{}", e) to .panic_any(e). Clippy suggested the latter but it caused errors in #221 on the old version. How about it?

rustc warns about panic!(err); being deprecated and either panic!("{}", e); or panic_any!(e)to replace it. We hadpanic!(err)in a couple of places and I fixed those in #222 to usepanic!("{}", e)`.
They are only in tests:

❯ rg 'panic.\("\{\}", err'
src/backend/impl_lmdb/arch_migrator.rs
773:                Err(err) => panic!("{}", err),
775:                    Err(err) => panic!("{}", err),

tests/env-lmdb.rs
1519:                Err(err) => panic!("{}", err),

tests/env-safe.rs
1242:                Err(err) => panic!("{}", err),

No point in touching those.

@saschanaz
Copy link
Collaborator

Ah yes, I somehow thought I saw more but I'm wrong 😬, sorry. Thanks for correcting me.

@saschanaz saschanaz merged commit 255fb41 into main Aug 12, 2022
@saschanaz saschanaz deleted the bump-msrv branch August 12, 2022 17:24
@saschanaz saschanaz mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants