Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokei output compatibility #104

Closed
2 of 3 tasks
lu-zero opened this issue Mar 5, 2020 · 5 comments
Closed
2 of 3 tasks

Tokei output compatibility #104

lu-zero opened this issue Mar 5, 2020 · 5 comments

Comments

@lu-zero
Copy link
Collaborator

lu-zero commented Mar 5, 2020

See tokei

  • tabular output
  • json output
  • cbor/toml/yaml output
@Luni-4
Copy link
Collaborator

Luni-4 commented Apr 3, 2020

The tabular output would be difficult to read because rust-code-analysis has lots of metrics compared to Tokei. The json output is already implemented.

@lu-zero
Copy link
Collaborator Author

lu-zero commented Apr 3, 2020

Having a table per-metric should solve the problem of having way too many columns I guess.

I do not have strong opinions in this regard, but would be nice to have a way to see the data from the cli w/out piping the json to something that formats it though.

@Luni-4
Copy link
Collaborator

Luni-4 commented Apr 3, 2020

I do not have strong opinions in this regard, but would be nice to have a way to see the data from the cli w/out piping the json to something that formats it though.

Right, but for now the tabular option has low-priority compared to your third item :)

@Luni-4 Luni-4 self-assigned this Apr 3, 2020
@Luni-4
Copy link
Collaborator

Luni-4 commented Apr 27, 2020

The tabular format presents a series of problems.

Let m be the number of files in a directory, n the number of function spaces and k the number of tables. Let also suppose that each struct is represented by a table.

The final number of tables is then equal to: m * n * k
if the values of the three variables are pretty large, we would get an enormous output, difficult to analyze.

Possible approaches could be the following ones:

  • Print only global metrics for each file
  • Print only determined metrics for each file and function space
  • Do not implement the tabular approach for rust-code-analysis

@Luni-4 Luni-4 removed their assignment Jun 30, 2020
@Luni-4
Copy link
Collaborator

Luni-4 commented Jul 1, 2020

Closed in favor of #163

@Luni-4 Luni-4 closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants