Remove unused abi attributes. #9606
Conversation
|
Oh no! I didn't know that. :( Close whichever one makes sense. I just picked a random issue from easy and did it. |
|
It looks like this one covers the FFI dox when the other doesn't, so how about this one takes care of the dox and the other takes care of the compiler? |
|
Seems fine. Should I rebase to remove all of that? |
|
#9604 hasn't seen a lot of action in the past week or so, so I think it's ok to just rebase and continue on with this as it was originally. |
|
yeah pls do, looking into the compiler code proves to be very challenging to me :( |
|
Done! |
|
That needed a rebase quickly :(, Also I think that |
|
Okay! I think this is good to go now. |
|
I'm pretty sure you should just omit all the |
|
What im most confused about is why 'make check' Works On My Machine (tm) |
| @@ -107,8 +106,7 @@ pub mod c_float_utils { | |||
| use libc::{c_float, c_int}; | |||
|
|
|||
| #[link_name = "m"] | |||
| #[abi = "cdecl"] | |||
| extern { | |||
| extern "cdecl" { | |||
There was a problem hiding this comment.
I think this caused build error on android: cdecl is only available on X86/64, not on ARM.
There was a problem hiding this comment.
Gotcha. is this something that changed? Since I'm just moving things around...
They've been replaced by putting the name on the extern block.
#[abi = "foo"]
goes to
extern "foo" { }
Closes rust-lang#9483.
|
Okay. I removed the declarations. I didn't have time to wait for full compilation, because I'm getting on a plane, but it got through the first few stages. If bors isn't busy... ;) |
They've been replaced by putting the name on the extern block.
#[abi = "foo"]
goes to
extern "foo" { }
Closes #9483.
They've been replaced by putting the name on the extern block.
#[abi = "foo"]
goes to
extern "foo" { }
Closes #9483.