-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response file parsing for GCC and Clang does not handle quoted arguments #1780
Comments
Alexei-Barnes
added a commit
to Alexei-Barnes/sccache
that referenced
this issue
May 31, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
Alexei-Barnes
added a commit
to Alexei-Barnes/sccache
that referenced
this issue
May 31, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
Alexei-Barnes
added a commit
to Alexei-Barnes/sccache
that referenced
this issue
May 31, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
Alexei-Barnes
added a commit
to Alexei-Barnes/sccache
that referenced
this issue
Jun 1, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
sylvestre
pushed a commit
to Alexei-Barnes/sccache
that referenced
this issue
Jun 1, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
sylvestre
pushed a commit
to Alexei-Barnes/sccache
that referenced
this issue
Jun 1, 2023
This fixes mozilla#1780 This moves the response file parsing code implemented by @temportalflux out of the MSVC compiler and shares it for all compilers. This enables GCC and Clang to use response files with quoted arguments. I've added some lib tests to the response file module, so that it can be reasoned about, separately from the compilers using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unreal Engine uses response files with compilation, even when using Clang on Linux. Some of the arguments in these response files contain quotation marks. Conveniently, we already have nice parsing for response files for MSVC that handle this case, but unfortunately, we don't have this for GCC or Clang.
The text was updated successfully, but these errors were encountered: