Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove beta build #700

Closed
wants to merge 1 commit into from
Closed

CI: remove beta build #700

wants to merge 1 commit into from

Conversation

ry
Copy link
Contributor

@ry ry commented Mar 12, 2020

The beta build is broken since Rust 1.42.0 was released because blake
0.1.1 is broken in 1.43.0-beta.1. Since sccache is an executable, not a
library, it's not very useful to test the build under many different
versions of Rust.

Fixes #699

The beta build is broken since Rust 1.42.0 was released because blake
0.1.1 is broken in 1.43.0-beta.1. Since sccache is an executable, not a
library, it's not very useful to test the build under many different
versions of Rust.
@froydnj
Copy link
Contributor

froydnj commented Mar 12, 2020

I understand the sentiment, but it sounds like there is a fixed version of blake (0.1.5) and I think I would rather address issues as they come along, rather than stable suddenly turning builds red and having to figure out what's going on with several crates.

Can we just update the version of blake instead?

@ry
Copy link
Contributor Author

ry commented Mar 12, 2020

Sure, but I'd be interested in knowing what the benefit to supporting nightly, beta, and 1.36 are when sccache itself has no dependents. It's just more to manage - for example we cannot upgrade to the latest blake3 0.2.2 because we must also be backwards compatible with Rust 1.36. Likely the travis config for sccache was just copied from another Rust library which has actual concerns about dependents.

#701

@ry ry closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI red after 1.42.0 release
2 participants