Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to cache lookups and handle server eofs #79

Merged
merged 3 commits into from
Mar 25, 2017
Merged

Add timeouts to cache lookups and handle server eofs #79

merged 3 commits into from
Mar 25, 2017

Commits on Mar 24, 2017

  1. Add some logging to server shutdown

    @alexcrichton
    alexcrichton committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    87c5b7b View commit details
    Browse the repository at this point in the history

  2. Handle UnexpectedEof from server by compiling locally 

    I believe this is possible to hit if the compilation takes quite a long time and
times out the server itself. The server may shut down due to being idle while
we're still connected and cause us to receive an `UnexpectedEof`.
    @alexcrichton
    alexcrichton committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    6efac2e View commit details
    Browse the repository at this point in the history

  3. Add a timeout to cache lookups 

    This should help ensure that we don't wait *too* long for the cache to respond
(for example on an excessively slow network) and time out the server
unnecessarily.
    @alexcrichton
    alexcrichton committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    b91b81a View commit details
    Browse the repository at this point in the history