Remove dependency on named_pipe
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I took this as an opportunity as well to remove the raw call to |
|
This looks great (thanks for the CreateProcess cleanup!) There are just two things that I'd like fixed before you merge this:
|
I was sporadically receiving a segfault locally when trying to debug issues on Windows and in tracking this down I discovered blackbeam/named_pipe#3 which leads to segfaults locally on startup. This switches the one use case to the relevant functionality in `mio-named-pipes` (already pulled in as part of `tokio-process`) and then otherwise mirrors the same logic as the Unix version, just waiting for a byte with a timeout.
alexcrichton
force-pushed
the
fix-named-pipes
branch
from
5e939d3
to
9ad1bc9
Compare
|
Certainly, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was sporadically receiving a segfault locally when trying to debug issues on
Windows and in tracking this down I discovered blackbeam/named_pipe#3 which
leads to segfaults locally on startup.
This switches the one use case to the relevant functionality in
mio-named-pipes(already pulled in as part oftokio-process) and thenotherwise mirrors the same logic as the Unix version, just waiting for a byte
with a timeout.