script: Fix background color of Acid2. #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/1021 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewed on Critic. |
|
Comments addressed. r? @SimonSapin |
| /// | ||
| /// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html# | ||
| /// space-character | ||
| pub fn is_space_character(ch: char) -> bool { |
There was a problem hiding this comment.
Is there a reason not to use ['\u0020', '\u0009', '\u000a', '\u000c', '\u000d'] and get the CharEq implementation for free?
There was a problem hiding this comment.
Perhaps call it something with "html" in the name, to disambiguate in case different specs have different opinions of what’s a space.
There were two problems here: (1) we did not process style sheets with an unexpected `rel` attribute but a correct MIME type; (2) we did not consider `none` a valid value for the `background` property.
|
Comments addressed, r? @SimonSapin |
bors-servo
pushed a commit
that referenced
this pull request
Mar 14, 2014
There were two problems here: (1) we did not process style sheets with an unexpected `rel` attribute but a correct MIME type; (2) we did not consider `none` a valid value for the `background` property. r? @SimonSapin
bors-servo
pushed a commit
that referenced
this pull request
Mar 14, 2014
There were two problems here: (1) we did not process style sheets with an unexpected `rel` attribute but a correct MIME type; (2) we did not consider `none` a valid value for the `background` property. r? @SimonSapin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems here: (1) we did not process style sheets with an
unexpected
relattribute but a correct MIME type; (2) we did notconsider
nonea valid value for thebackgroundproperty.r? @SimonSapin