This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
add task to run locally #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidler-mozilla
force-pushed
the
run-locally
branch
9 times, most recently
from
c0d191d
to
a2e77c2
Compare
sidler-mozilla
force-pushed
the
run-locally
branch
from
a2e77c2
to
8e93adc
Compare
lmorchard
reviewed
May 17, 2019
lmorchard
reviewed
May 17, 2019
sidler-mozilla
force-pushed
the
run-locally
branch
from
8e93adc
to
132171a
Compare
lmorchard
reviewed
May 17, 2019
sidler-mozilla
force-pushed
the
run-locally
branch
from
132171a
to
2b774ca
Compare
marty331
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big commit with lots of changes:
multiple entries with more detail for all of the doit tasks available. This can probably still use more, but this is a big improvement for now.
The setup task is removed in favor of npm which operates at the REPOROOT rather than on each service/. Task for setting up venv has been added and task for starting and stopping dyanlite local db. These tasks are in support of the new local task for running the subhub flask app locally.
These files were moved to the REPOROOT of the git repo.
Several properties were added for use with the CFG.
The pathing was adjusted to match node_modules in the REPOROOT. Added use of DYNALITE_PORT.
Added tests for new properties to bring coverage to 98%. It doesn't seem possible to get to 100% due to the nature of the code.