Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

SS-234 Update Webhook Events #83

Merged
merged 1 commit into from
Jun 4, 2019
Merged

SS-234 Update Webhook Events #83

merged 1 commit into from
Jun 4, 2019

Conversation

marty331
Copy link
Contributor

@marty331 marty331 commented Jun 4, 2019

  • Added webhooks for:
    • invoice.finalized
    • invoice.payment_succeeded
    • customer.subscription.updated
    • customer.source.expiring
    • invoice.payment_failed
  • Added tests for all new webhooks

sidler-mozilla
sidler-mozilla approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@sidler-mozilla sidler-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider removing the dead code and repeated comments (if not necessary)

subhub/api/webhooks/stripe/controller.py Show resolved Hide resolved
subhub/api/webhooks/stripe/invoices.py Outdated Show resolved Hide resolved
@marty331
SS-234 Update Webhook Events
d55ee23 
- Added webhooks for:
  - invoice.finalized
  - invoice.payment_succeeded
  - customer.subscription.updated
  - customer.source.expiring
  - invoice.payment_failed
- Added tests for all new webhooks
@marty331 marty331 merged commit 5af6791 into master Jun 4, 2019
@marty331 marty331 deleted the add-webhook-events branch June 4, 2019 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sidler-mozilla sidler-mozilla sidler-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marty331 @sidler-mozilla