Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No results found - behaviour [Search pages] #134

Closed
ovidiuboca1 opened this issue Jan 27, 2020 · 4 comments
Closed

No results found - behaviour [Search pages] #134

ovidiuboca1 opened this issue Jan 27, 2020 · 4 comments
Assignees
@akatsoulas
Labels
bug Something isn't working
Milestone
Responsive redesign

Comments

@ovidiuboca1
Copy link

ovidiuboca1 commented Jan 27, 2020 •
edited
Loading

STR:

  1. Go to https://test.sumo.mozit.cloud/en-US/
  2. Perform a search after "mo"

ER: The message "Sorry! 0 results found for mo" is displayed. mockups- https://app.zeplin.io/project/5db3524d3cd0612c5d2f78a9/screen/5e1cd98da87828a8c7934700
AR: The message "We couldn't find any results for ‘mo’ in ‘English’. Maybe one of these articles will be helpful? " is displayed.
NOTE: Also the page UI is different from the one presented in the mockups.
@ovidiuboca1 ovidiuboca1 added the bug Something isn't working label Jan 27, 2020
@ovidiuboca1 ovidiuboca1 added this to the Responsive redesign milestone Jan 27, 2020
@ovidiuboca1 ovidiuboca1 changed the title No results found behaviour [Search pages] No results found - behaviour [Search pages] Jan 27, 2020
@ovidiuboca1 ovidiuboca1 mentioned this issue Jan 27, 2020
Closed
@kkellydesign
Copy link

This layout is in and will be updated when this goes live: mozilla/kitsune#4150

Screen Shot 2020-01-28 at 6 05 21 PM

@akatsoulas I'll need a hand on the backend with this – I couldn't get the product name or "ask a question" URL to cooperate from the nunjucks template. You can see the "todo" item here:

Screen Shot 2020-01-28 at 6 05 27 PM

kkellydesign added a commit to lincolnloop/kitsune that referenced this issue Jan 28, 2020
@kkellydesign
'no results' search layout finished. ref mozilla/sumo#134
9343976
akatsoulas pushed a commit to akatsoulas/kitsune that referenced this issue Jan 31, 2020
@kkellydesign @akatsoulas
Search fixes.
9f78493 
* fix search on document pages
* 'no results' search layout finished.
  ref mozilla/sumo#134
* masthead search now works across all templates
@kkellydesign
Copy link

This is ready to be tested. Note the the icon links are broken currently – that will be fixed when mozilla/kitsune#4170 goes live.

@kkellydesign
Copy link

@akatsoulas also note that this still needs some BE integration here (detailed above): https://github.com/mozilla/kitsune/blob/responsive-redesign/kitsune/sumo/static/sumo/tpl/search-results-list.html#L143-L147

akatsoulas pushed a commit to akatsoulas/kitsune that referenced this issue Mar 12, 2020
@kkellydesign @akatsoulas
Search fixes.
01b7985 
* fix search on document pages
* 'no results' search layout finished.
  ref mozilla/sumo#134
* masthead search now works across all templates
@kkellydesign
Copy link

The copy was changed in the component in question, so my last todo item on this ticket isn't valid anymore. This is safe to be closed.
Screen Shot 2020-03-19 at 11 07 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akatsoulas akatsoulas

Labels
bug Something isn't working
Projects
None yet
Milestone
Responsive redesign
Development

No branches or pull requests
3 participants
@kkellydesign @akatsoulas @ovidiuboca1