Features/locale weights #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reworked the LazyS3 loader to accept an optional transform function to modify the JSON on load. * Dropped dead testcase and clarified name for another testcase.
crankycoder
force-pushed
the
features/locale_weights
branch
from
8ebd60d
to
e0b850c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top10_dict.json file for the LocaleRecommender now includes weights for each of the GUIDs.
LocaleRecommender was previously using hard coded weights of 1.0 for each GUID.
This patch properly uses the weights in the JSON file. Support to presort the JSON data has been added to the LazyS3 JSON loader as well.