Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable randomization #184

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Enable randomization #184

merged 3 commits into from
Dec 21, 2020

Conversation

eu9ene
Copy link
Contributor

@eu9ene eu9ene commented Dec 19, 2020

We want to deploy randomization to prod on a permanent basis. Before it was implemented as an optional experiment.

  • removed in_experiment check
  • fixed problem with crash on possible negative weights

Closes #182

@jasonthomas
Copy link
Member

Copy link
Member

@jasonthomas jasonthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

@eu9ene
Copy link
Contributor Author

eu9ene commented Dec 21, 2020

Can https://github.com/eu9ene/taar/blob/2750e316562c9dfc3e2b039877b829ccb6d6cdd6/taar/settings.py#L48 also be removed now?

yes, I didn't commit it, thanks!

@eu9ene eu9ene closed this Dec 21, 2020
@eu9ene eu9ene reopened this Dec 21, 2020
@eu9ene eu9ene merged commit 754b402 into mozilla:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix randomization
2 participants