-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
Another option may be to use something like gulp-base64 to inline the 2 images into the final CSS/Sass files to remove the need to manage the /media assets. |
@@ -0,0 +1,39 @@ | |||
@import 'bourbon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make bourbon a dependency for a single mixin used only once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shrug It does seem like overkill. We could just make a custom mixin to do the media query (or hard code it).
@jpetto Replaced the node-bourbon dependency with an inline |
If we did this, it would be good to make it optional perhaps. I believe some really old browsers (cough IE) may throw insecure content warnings on base64 inline images. Might not be an issue for most web sites, but this tab gets used in a lot of places. |
Also not to bikeshed, but curious why the switch to Sass? I was under the impression Less was more commonly used on Mozilla sites (or Stylus). (Fwiw, personally I do like Sass - just not as common to see it used here as other pre-processors) |
62212ee
to
567cb69
Compare
@alexgibson No real reason, just that our projects use Sass and this would make it easier to integrate. |
@alexgibson See alternate #76 PR for adding basic Sass support while sticking w/ LESS. |
Re: Sass vs LESS, I saw this the other day: http://ashleynolan.co.uk/blog/frontend-tooling-survey-2015-results Sass: 66% |
This is indeed very true in the wider web dev world. I only mentioned it here because the majority of moz sites seem to be Django/Python based. |
This commit adds a /css/_tabzilla.scss file and you can do
require('mozilla-tabzilla').includePaths
(orrequire('mozilla-tabzilla').with(['path1', 'path2'])
) so you can do@import 'tabzilla';
from your .scss files.Fixes #74