Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1864100 - Include the original job type name and job type symbol in search string. #7870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arai-a
Copy link
Contributor

@arai-a arai-a commented Nov 10, 2023

for https://bugzilla.mozilla.org/show_bug.cgi?id=1864100

this patch changes two things:

  • include the original job type name and job type symbol in the job's searchStr
    • this allows filtering the job including chunk number, that is the text copied by the copy button for "Job name" in the job info
  • (as a side effect) use the original job type name in the hover text

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cf69e68) 76.83% compared to head (48e6dc9) 76.84%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7870   +/-   ##
=======================================
  Coverage   76.83%   76.84%           
=======================================
  Files         538      538           
  Lines       26621    26627    +6     
  Branches     3360     3362    +2     
=======================================
+ Hits        20455    20461    +6     
  Misses       6001     6001           
  Partials      165      165           
Files Coverage Δ
ui/helpers/job.js 93.80% <92.85%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants