fix: web-ext sign now exits with a non-zero status if signing fails (#586)

Author: shubheksha

src/cmd/sign.js

@@ -5,7 +5,7 @@ import defaultAddonSigner from 'sign-addon';
 
 import defaultBuilder from './build';
 import {withTempDir} from '../util/temp-dir';
-import {isErrorWithCode, UsageError} from '../errors';
+import {isErrorWithCode, UsageError, WebExtError} from '../errors';
 import getValidatedManifest, {getManifestId} from '../util/manifest';
 import {prepareArtifactsDir} from '../util/artifacts';
 import {createLogger} from '../util/logger';
@@ -120,6 +120,8 @@ export default function sign(
         log.info('SUCCESS');
       } else {
         log.info('FAIL');
+        throw new WebExtError(
+          'The WebExtension could not be signed');
       }
 
       return signingResult;

tests/unit/test-cmd/test.sign.js

@@ -7,7 +7,7 @@ import {assert} from 'chai';
 import sinon from 'sinon';
 import promisify from 'es6-promisify';
 
-import {onlyInstancesOf, UsageError} from '../../../src/errors';
+import {onlyInstancesOf, UsageError, WebExtError} from '../../../src/errors';
 import {getManifestId} from '../../../src/util/manifest';
 import {withTempDir} from '../../../src/util/temp-dir';
 import {basicManifest, manifestWithoutApps} from '../test-util/test.manifest';
@@ -248,8 +248,11 @@ describe('sign', () => {
             success: false,
           }),
         })
-        .then((result) => {
-          assert.equal(result.success, false);
+        .then(makeSureItFails())
+        .catch((error) => {
+          assert.instanceOf(error, WebExtError);
+          assert.match(error.message,
+            /The WebExtension could not be signed/);
         });
     }
   ));