Skip to content

Commit ee422b7

Browse files
shubhekshakumar303
authored andcommitted
fix: disabled caching during npm run lint (#434)
* fix: disabled caching during npm run lint * fix: enabled caching for npm start & disabled for npm run test * refactor: changed the linting task to lint for npm run test * refactor: removed support for old node versions * refactor: removed all instances of semver
1 parent ba60e9f commit ee422b7

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

Gruntfile.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/*eslint prefer-template: 0*/
22
var path = require('path');
33
var spawn = require('child_process').spawn;
4-
var semver = require('semver');
54

65
module.exports = function(grunt) {
76

@@ -48,12 +47,9 @@ module.exports = function(grunt) {
4847
grunt.registerTask('lint', 'checks for syntax errors', function() {
4948
if (process.env.SKIP_LINT) {
5049
grunt.log.writeln('lint task skipped because of $SKIP_LINT');
51-
} else if (semver.satisfies(process.version, '< 4.0.0')) {
52-
// eslint now requires a new-ish Node.
53-
grunt.log.writeln('task skipped because this version of Node is too old');
5450
} else {
5551
grunt.task.run([
56-
'newer:eslint',
52+
'eslint',
5753
]);
5854
}
5955
});

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
"load-grunt-tasks": "3.5.2",
9696
"mocha": "3.0.2",
9797
"mocha-multi": "0.9.1",
98-
"semver": "5.3.0",
9998
"sinon": "1.17.5",
10099
"webpack": "1.13.1",
101100
"webpack-dev-server": "1.14.1",

tasks/watch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = {
1616
'flowbin:status',
1717
'build-tests',
1818
'mochaTest',
19-
'lint',
19+
'newer:eslint',
2020
],
2121
},
2222
};

0 commit comments

Comments
 (0)