Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firefox-android): Support abstract sockets for RDB #1391

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

A1kmm
Copy link
Contributor

@A1kmm A1kmm commented Nov 3, 2018

New versions of firefox-android appear to use abstract unix sockets instead of filesystem sockets
for the debugging connection. This change ensures support for both the original filesystem
namespace and also the abstract namespace.

New versions of firefox-android appear to use abstract unix sockets instead of filesystem sockets
for the debugging connection. This change ensures support for both the original filesystem
namespace and also the abstract namespace.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ecfc06f on A1kmm:abstract-sockets into 9d28fb8 on mozilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ecfc06f on A1kmm:abstract-sockets into 9d28fb8 on mozilla:master.

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A1kmm Thanks a lot for digging into this issue and preparing a fix for it (as well as including the needed changes to the unit tests, it has been very much appreciated!)

The changes included in the PR looks great to me, I'm going to give this branch a try locally on an android emulator asap (mainly to double-check the version of Firefox for Android that has introduced this change is Firefox for Android 63, at least based on the issues related to this that I found in a quick search on bugzilla, and also because this part is not covered by any functional test).

Nevertheless, in the meantime I'm marking this PR as reviewed right now.

@rpl
Copy link
Member

rpl commented Nov 8, 2018

Just verified this PR locally, and it fixes (as expected) the issue with "forwarding and connecting the Fennec remote debugging server socket" for both Firefox for Android 63.0.2 (the currently released version) and Firefox for Android Beta 64.0b7.

@A1kmm Thanks again for this PR!

@rpl rpl merged commit 46f0cfe into mozilla:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants