fix: improve and test importing web-ext as an ESM module or requiring as a CommonJS module #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rob--W no need to rush to review this, as I wrote in the description this isn't something that we should include in the upcoming v. 4.3.0 (I added it in the backlog of the next major release, v5.0.0), but I did pushed it so that we can evaluate this approach (and test coverage for this) in the meantime. |
Rob--W
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a small set of proposed tweaks to improve a bit (and cover with tests) how web-ext can be used as a library, imported as an ESM module or required as a CommonJS module.
Given that this change what web-ext is going to export when loaded as a module, it would be likely better to be included in a major release (to avoid to break npm packages that may depend on the current exports).
Other pull requests related to this: