Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Node 18 in Circle CI #2618

Merged
merged 1 commit into from
Jan 20, 2023
Merged

ci: use Node 18 in Circle CI #2618

merged 1 commit into from
Jan 20, 2023

Conversation

willdurand
Copy link
Member

Fixes #2617

@willdurand willdurand changed the title Use Node 18 in Circle CI ci: use Node 18 in Circle CI Jan 19, 2023
@willdurand willdurand marked this pull request as ready for review January 19, 2023 15:25
@willdurand willdurand requested a review from rpl January 19, 2023 15:25
@willdurand
Copy link
Member Author

Looks like it's working :)

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 99.52% // Head: 99.52% // No change to project coverage 👍

Coverage data is based on head (4899253) compared to base (6356fa9).
Patch has no changes to coverable lines.

❗ Current head 4899253 differs from pull request most recent head 32d7e5a. Consider uploading reports for the commit 32d7e5a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2618   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1691     1691           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willdurand willdurand merged commit 0bf4881 into master Jan 20, 2023
@willdurand willdurand deleted the node-18 branch January 20, 2023 13:44
@yan12125 yan12125 mentioned this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Node 18 in Circle CI
2 participants