-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove sign-addon #2880
feat: remove sign-addon #2880
Conversation
82f71fe
to
b2e08d4
Compare
@willdurand I looked into the functional test failure and while I was there I thought to also rebase this PR to resolve the conflicts it got in the meantime, I'm about to push an update to this existing PR and branch to confirm that the functional tests will be passing when running as part of the CI job as they did when I was executing them locally (and that I didn't missed any other tests failing while we remove the sign-addon dependency). |
b2e08d4
to
f212056
Compare
… test to pass with the submit-addon API
f212056
to
b2cf0d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2880 +/- ##
==========================================
- Coverage 99.48% 99.31% -0.18%
==========================================
Files 32 32
Lines 1761 1753 -8
==========================================
- Hits 1752 1741 -11
- Misses 9 12 +3
☔ View full report in Codecov by Sentry. |
Excellent, thanks! |
Fixes #2737