Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sign-addon #2880

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: remove sign-addon #2880

merged 2 commits into from
Nov 10, 2023

Conversation

willdurand
Copy link
Member

Fixes #2737

@willdurand willdurand force-pushed the remove-sign-addon branch 3 times, most recently from 82f71fe to b2e08d4 Compare September 14, 2023 08:56
@willdurand willdurand marked this pull request as draft September 14, 2023 09:59
@fregante
Copy link
Contributor

fregante commented Oct 8, 2023

dat lockfile diff 🥵

Screenshot

@rpl
Copy link
Member

rpl commented Nov 6, 2023

@willdurand I looked into the functional test failure and while I was there I thought to also rebase this PR to resolve the conflicts it got in the meantime, I'm about to push an update to this existing PR and branch to confirm that the functional tests will be passing when running as part of the CI job as they did when I was executing them locally (and that I didn't missed any other tests failing while we remove the sign-addon dependency).

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd8c082) 99.48% compared to head (b2cf0d5) 99.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
- Coverage   99.48%   99.31%   -0.18%     
==========================================
  Files          32       32              
  Lines        1761     1753       -8     
==========================================
- Hits         1752     1741      -11     
- Misses          9       12       +3     
Files Coverage Δ
src/cmd/sign.js 94.73% <100.00%> (-5.27%) ⬇️
src/program.js 98.58% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand
Copy link
Member Author

Excellent, thanks!

@rpl rpl merged commit 716339d into master Nov 10, 2023
5 of 6 checks passed
@rpl rpl deleted the remove-sign-addon branch November 10, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sign-addon dependency
3 participants