Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web-ext lint: ignore node_modules and other artifacts #405

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Aug 2, 2016

Fixes #397

Tasks:

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 3aeda8a on kumar303:lint-filter into 0c54b95 on mozilla:master.

@rpl
Copy link
Member

rpl commented Aug 4, 2016

👍 lgtm, once the updated addons-linter has been released (and the its version in our package.json updated accordingly), I think that this is ready to go.

r+

@kumar303 kumar303 merged commit cd9adac into mozilla:master Aug 4, 2016
@kumar303 kumar303 deleted the lint-filter branch August 4, 2016 18:59
@pdehaan
Copy link
Contributor

pdehaan commented Aug 4, 2016

Any chance we're deploying a 1.4.0 release to npm with this fix in?

@kumar303
Copy link
Contributor Author

kumar303 commented Aug 4, 2016

@pdehaan sure, I can cut a new release right now

@kumar303
Copy link
Contributor Author

kumar303 commented Aug 4, 2016

when this is finished building the release should be on npm: https://travis-ci.org/mozilla/web-ext/builds/149854164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants