This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Implement support for extension commands. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for extension commands by adding an Extension(T:WebDriverExtensionRoute) entry to the httpapi::Route enum and Extension(T:WebDriverExtensionCommand) to command::WebDriverCommand. Users must pass a list of all the extension routes they want to use when calling server::start. They will also need to ensure that their WebDriverHandler implementation has the extesnion route type as a type argument
|
Critic review: https://critic.hoppipolla.co.uk/r/5787 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
These changes seem reasonable to me. I guess it might be nice to see what the downstream consumer changes look like? |
|
Yeah, I was about to make a PR, when it turned out that I'd made a mess of try. PR coming up. |
|
Yep, looks good to me. |
jgraham
added a commit
that referenced
this pull request
Sep 4, 2015
Implement support for extension commands.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for extension commands by adding an Extension(T:WebDriverExtensionRoute)
entry to the httpapi::Route enum and Extension(T:WebDriverExtensionCommand) to
command::WebDriverCommand. Users must pass a list of all the extension routes they want
to use when calling server::start. They will also need to ensure that their WebDriverHandler
implementation has the extesnion route type as a type argument