This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
Force retry error message if error hangs logout (bug 886742) #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,14 @@ | |||
| require(['cli', 'id', 'auth', 'pay/bango', 'lib/longtext'], function(cli, id, auth, bango, checkLongText) { | |||
| "use strict"; | |||
|
|
|||
| var LOGOUTTIMEOUT = 30000; | |||
There was a problem hiding this comment.
it would be nice to adjust this from settings, you could do switch it to cli.bodyData.logoutTimeout
|
r+wc. After the settings change, I say merge it in. It can become more general as you tackle the others in https://bugzilla.mozilla.org/show_bug.cgi?id=876808 |
muffinresearch
added a commit
that referenced
this pull request
Aug 9, 2013
…86742 Force retry error message if error hangs logout (bug 886742)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a retry error message if something hangs up the logout. Mainly this would be something like bango having a 500 which doesn't cause a failBack in the request.
To test it then there's this patch [1] which makes the bangoLogout fail the first time around and succeed the second - just adapt the mp.mozilla.dev line to point at your webpay (I found this works best if you set it to a different host than the way you're requesting webpay - I think it's that that's at the root of causing the non-failure in the 500 when the data type is script as it fails as expected if the host matches the request).
The default timeout is 30s which may or may not be too long - I'm happy to take suggestions on that.
[1] https://gist.github.com/muffinresearch/1a4675c2d39e3e7c0ee4