-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
Thanks for the pull request, and welcome! The following reviewer was randomly selected for this PR: @jgraham |
Works for me. Left a few comments. @jgraham will have a better idea about the CSS and what the UI should be 😄 Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions. index.html, line 9 [r1] (raw file): index.html, line 139 [r1] (raw file): index.html, line 148 [r1] (raw file): Comments from the review on Reviewable.io |
Reviewed 3 of 3 files at r1. Comments from the review on Reviewable.io |
attempts to fix #13 |
@martiansideofthemoon In the html file there were no spaces around '=' so I kept it like that |
@CodeMaxx , the |
A tag will make the result( ERROR , SKIP etc) get underlined. Instead I'm thinking of adding some CSS to change the pointer. I hope thats not a problem. |
@CodeMaxx , yeah didn't think of that. Should do! |
r+ from my side. One nit to fix. Won't merge till @jgraham sees this. Reviewed 2 of 2 files at r2. index.html, line 139 [r2] (raw file): Comments from the review on Reviewable.io |
Reviewed 1 of 1 files at r3. index.html, line 139 [r1] (raw file): Why do you need to stop the event propagation? You can't use index.html, line 148 [r1] (raw file): wptview.css, line 21 [r3] (raw file):
And the panel should have a white background, be opaque, have a top border, and cover the full width of the screen (see https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a05aefe2c48a&selectedJob=20791532 or something for a clearer idea of how it should look). Ideally we could also find some way to indicate which cell is selected. Comments from the review on Reviewable.io |
All done except highlighting the cell which is seen. |
@jgraham How do you want the clicked error to be highlighted? (change in background color, a thick border around the box etc.) |
How about using the Reviewed 2 of 3 files at r4. angular_scripts.js, line 131 [r4] (raw file): index.html, line 149 [r4] (raw file): index.html, line 151 [r4] (raw file): wptview.css, line 21 [r3] (raw file): wptview.css, line 28 [r4] (raw file): Comments from the review on Reviewable.io |
Reviewed 1 of 3 files at r4. Comments from the review on Reviewable.io |
@CodeMaxx , could you rebase here? |
Added the basic functionality. Need some pointers on the design of the panel showing the errors.