Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in with MoCo on their use of django #13

Closed
Pomax opened this issue Jan 11, 2017 · 8 comments
Closed

Check in with MoCo on their use of django #13

Pomax opened this issue Jan 11, 2017 · 8 comments
Assignees
@Pomax @kristinashu

Comments

@Pomax
Copy link
Contributor

Pomax commented Jan 11, 2017

We will want to check in with pmac and tasos to find out how django is being used on the MoCo side, specifically in terms of the following questions:

  • What django bolt-ons are they using?
  • Who are they giving django access to?
  • How many people are usually “needed” to be on that to keep it running (i.e. what is the general FTE commitment necessary to keep things up and running)
@Pomax Pomax mentioned this issue Jan 11, 2017
Closed
@Pomax Pomax self-assigned this Jan 11, 2017
@Pomax Pomax added the django label Jan 11, 2017
@Pomax Pomax changed the title [django] Check in with MoCo on their use of django Check in with MoCo on their use of django Jan 11, 2017
@kristinashu
Copy link

kristinashu commented Jan 11, 2017 •
edited
Loading

It would also be helpful to have a list of Mozilla sites that get updated by program staff (and volunteers?) in a django interface. This will help determine who to interview in #11 and which bolt-ons might be relevant to review in #12

@kristinashu
Copy link

kristinashu commented Jan 11, 2017 •
edited
Loading

Meetings are set with pmac and jwhitlock for later this week.

http://etherpad.io/p/moco_django

@kristinashu
Copy link

Notes from meeting with pmac:

  • he works on bedrock where the admin is very basic (Program staff just add newsletter link to site) so it isn't the best example
  • bolt-ons:
  • who has access
    • staff
    • close contributors (thunderbird team release note)
  • security reviews are an issue
    • join the django security mailing list/bugzilla group to get sec.issues before they go public
  • big jumps from version to version that break bolt-ons and grappelli
  • others people to talk to:
    • Osmose (Michael Kelly)
    • someone from sumo (will ask roland at office who to ask)
    • someone from MDN (if django rather than wiki): jwhitlock and will ask Stephanie at office

@kristinashu kristinashu self-assigned this Jan 12, 2017
@kristinashu
Copy link

kristinashu commented Jan 13, 2017 •
edited
Loading

Notes from meeting with jwhitlock:

  • he works on kuma for MDN https://github.com/mozilla/kuma
  • direct admin pages access for staff and longterm contributors (to be locked down soon though due to security)
  • you log into a front end and then you get to work with the backend data
  • different tiers of access for different people (view vs edit privaleges)
  • provide step by step directions to Program staff for a small specif job
    • example: admin decide if a new edit to wiki is spam or not. They see list, can filter, see detail, then chose from a dropdown if spam or not.
  • forms are tough
  • django is (was?) the basis for dynamic sites, DRF is an option but you're going to be fighting the framework a bit
  • familiarity with the traditional concept (post to site -> page refresh, rather than ajaxy in-page stuff)
  • standard django with jinja2 templates
  • uses some custom JS for UI updating (example filtering list)
  • uses pantoon for mdn - in line edit and then save
  • handy util for python deps: requires.io to examing requirements.txt for deployed codebases (can flag green/stale/insecure/etc)
    codecov.io for code coverage
  • https://requires.io/github/mozilla/kuma/requirements/?branch=master
  • recommends we talk to pantoon people: Poke Osmose and Mathjazz for how they use django in pontoon

@kristinashu
Copy link

Jezdev mentioned these for CMS: https://www.django-cms.org/en/ and https://wagtail.io/

Django CMS looks excellent from a Program Staff usability stand point. Would be great to see how viable it is from an engineering stand point.

@kristinashu
Copy link

Notes from meeting with Matjaz:

Pontoon

  • currently one developer (matjaz), one volunteer (jotes) (~1.5 FTE)
  • the admin side is really just two custom views, actually considering switching to stock Django admin
    • the maintenance required is high because it would need work to look sleak (writing widgets, etc)
  • users:
    • purely volunteers (~700 active users - having contributed in the last 2 months)
    • hired agencies for legal translation
    • roles
      • logged in user (you can contribute suggestions)
      • translator (someone who can approve translations and submit own translations)
      • team manager (translator + able to give permissions to users)
      • admin (basically team members, able to add new projects, enable locales, full access to pontoon admin view as well as django admin view) (four people atm, 2 engineers, 2... might be...?)
  • "things have to be really simple" so no specific technical skills should be necessary to use the system
  • mostly stock Django
    • no third-party addons/skins/etc, view content is in-house
    • standard web techs like jquery, webfonts, etc.
    • originally used django oauth for logins
      • no auth0 (yet)
  • new project => basic data input into form that defines "a project", this then sets up a view that can load that project
  • every 20 minutes there is sync from pontoon django to the code repository, which then sets up all the pages (dynamic django views) and dashboard.

@kristinashu
Copy link

@Pomax I think we can close this ticket, agree?

@kristinashu kristinashu mentioned this issue Feb 9, 2017
Closed
@Pomax
Copy link
Contributor Author

Pomax commented Feb 9, 2017

yep, I think so.

@Pomax Pomax closed this as completed Feb 9, 2017
mmmavis added a commit that referenced this issue Jan 24, 2018
@mmmavis
# This is a combination of 17 commits.
2e24e4f 
# This is the 1st commit message:

fixed rebase conflicts

# This is the commit message #2:

fixed rebase conflicts

# This is the commit message #3:

fixed rebase conflicts

# This is the commit message #4:

updated elements on the page based on the latest comps

# This is the commit message #5:

added the last 2 sections in

# This is the commit message #6:

removed redundant code

# This is the commit message #7:

fixed rebase conflicts

# This is the commit message #8:

fixed rebase conflicts

# This is the commit message #9:

to match the updated comps

# This is the commit message #10:

fixed broken links

# This is the commit message #11:

named URL patterns

# This is the commit message #12:

custom template tag 'active_nav'

# This is the commit message #13:

applied custom template tag

# This is the commit message #14:

fixed linting error

# This is the commit message #15:

fixed linting error

# This is the commit message #16:

Related to #951 - fellowship type template & science fellowships

# This is the commit message #17:

featured fellow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pomax Pomax

@kristinashu kristinashu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pomax @kristinashu