Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close response bodies #15

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Daanikus
Copy link

Fix responses returned from Object methods whose bodies have not been closed. This leads to connections not being recycled.

Add CodeLingo tenet to catch this issue during code reviews.

I've fixed instances in example and test files, the Bucket struct may have similar issues which we can catch by editing the tenet. Are there other structs which may contain unclosed connections?

Signed-off-by: CodeLingo Bot <bot@codelingo.io>
Signed-off-by: CodeLingo Bot <bot@codelingo.io>
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #15 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #15   +/-   ##
========================================
  Coverage    96.27%   96.27%           
========================================
  Files           16       16           
  Lines          805      805           
========================================
  Hits           775      775           
  Misses          16       16           
  Partials        14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7198e5...7f0ab27. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants