parse headers to struct using reflection tags #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributor. Could you have time to add some tests for this feature? |
mozillazg
reviewed
Jan 17, 2021
|
@mozillazg I've added a test derived from real world usage of Google Calendar's header based notification system. Thanks for reviewing the PR and considering its inclusion. |
mozillazg
reviewed
Jan 19, 2021
|
@mozillazg thanks much! I'm working towards publishing the Google Calendar library. Do let me know if there's anything that I can do to get |
|
@bnfinet Just want to let you know, the new version of go-httpheader has been released today. BTW, I have updated some codes you can review these changes via v0.2.1...v0.3.0 . |
|
@mozillazg thank you! That's excellent test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
decoder.go