fix support for zsh 5.4.1 onwards #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 5.4.1, zsh won't allow the definition of functions using the `name()` syntax if `name` is already an alias. The recommended way to define functions is to always use the `function` keyword, as aliases are not expanded afterwards. See http://zsh.sourceforge.net/releases.html (5.3.1 to 5.4.1) and http://zsh.sourceforge.net/Doc/Release/Options.html#Scripts-and-Functions for more details.
|
So I assume you already had an alias for one of the functions? How does the error look like - out of curiosity? |
|
Yes, it's very common when using config frameworks for zsh like oh-my-zsh or prezto to have |
|
thank you :) |
|
Thanks for the fast merge! |
mpapis
added a commit
to rvm/rvm
that referenced
this pull request
Sep 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 5.4.1, zsh won't allow the definition of functions using the
name()syntax ifnameis already an alias.The recommended way to define functions is to always use the
functionkeyword, as aliases are not expanded afterwards.See http://zsh.sourceforge.net/releases.html (5.3.1 to 5.4.1) and http://zsh.sourceforge.net/Doc/Release/Options.html#Scripts-and-Functions for more details.