Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update to Support Unique OneTrust Versioning #13

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: Update to Support Unique OneTrust Versioning #13

merged 1 commit into from
Jan 10, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • With OneTrust's unique versioning and requirements to set SDK from a constrained list in their UI the best solution seemed to be to unpin from any specific OneTrust version and update the README to warn users that the must set this themselves.

Testing Plan

  • Tested using December release of OneTrust. Though this change doesn't change any functionality.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Jan 4, 2024
einsteinx2
einsteinx2 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BrandonStalnaker BrandonStalnaker merged commit e00b97a into development Jan 10, 2024
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/5970-Update-To-Support-Unique-OneTrust-Versioning branch January 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrandonStalnaker @einsteinx2