Add new barcode type C128RAW #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Please fix lint errors fot it to be merged. Also, add a unit test covering the edge cases of the new code branch. |
|
Tests added, and correct some discovered problems in subtype A and C |
|
Still some lint errors. When fixing, feel free to add your handle and the pull number to the changelog and then squash the commits to one. I'll be happy to merge this when done. |
|
If everything is fine please merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new barcode type C128RAW.
Needed to generate advanced barcodes.
For example: compressed alfa-numeric barcodes with subtype change in middle of barcode
"A1234567890" is possible to code only in 128A or 128B
<barcode code="A1234567890" type="C128A"/>with RAW type we can change the subtype after letter A
<barcode code="103 33 99 12 34 56 78 90" type="C128RAW"/>103 - start 128A
33 - "A"
99 - change to 128C
12 - "12" ...
check digit and stop are added automaticaly by library
same result with ~30% shorter barcode
more info https://en.wikipedia.org/wiki/Code_128