Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use manifold/connect for lazy-seq to stream #64

Merged
merged 2 commits into from
Aug 9, 2016

Conversation

mccraigmccraig
Copy link
Collaborator

the manifold buffered query implementation times-out because the lazy-seq of all pages of results is consumed synchronously and the attempt to put! all pages of results into the single page of stream buffer fails (unless there is a consumer keeping up presumably)

the PR uses manifold's own mechanism for connecting lazy seqs to stream, which only consumes from the seq when there is space in the stream buffer

@mpenet mpenet merged commit 67a6e7f into mpenet:master Aug 9, 2016
@mpenet
Copy link
Owner

mpenet commented Aug 9, 2016

Nice find thanks! I ll cut a release when I am back home.

@mpenet
Copy link
Owner

mpenet commented Aug 9, 2016

Fix available from [cc.qbits/alia-manifold "3.1.4"] . Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants