Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change auth key from :user to :username to match documentation. #10

Closed
wants to merge 1 commit into from
Closed

Change auth key from :user to :username to match documentation. #10

wants to merge 1 commit into from

Conversation

DCPRevere
Copy link

@DCPRevere DCPRevere commented Mar 6, 2017 •
edited
Loading

:basic-auth (map of :username :password)

Perhaps, I should make the change in the other direction? Changing the documentation wouldn't break existing usage.

Closes #11.

@mpenet
Copy link
Owner

mpenet commented Mar 7, 2017 •
edited
Loading

Hi,
I'd prefer the other way around yes (user/password).

Thanks for the report.

@mpenet mpenet closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DCPRevere @mpenet