Add support for wrapping bulk chan payloads with metadata #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limess
force-pushed
the
support-bulk-metadata
branch
from
5bd0b5c
to
e28d4a5
Compare
This is a non-breaking change, which allows users to pass arbitrary data into the bulk-chan, and then make use of it on the output channel. An example use case is correlating input with successes and failures. In our use case the elasticsearch ID may not be sufficient for this so extra metadata is required
Limess
force-pushed
the
support-bulk-metadata
branch
from
e28d4a5
to
9afe4db
Compare
|
Sorry I totally forgot about that one. Why can't you just use regular clojure metadata on the input request-map? |
|
I forgot the exact context, but I believe adding any metadata to the request will be sent to Elasticsearch, which won't accept it. We had the requirement of preserving context through spandex, without affecting the ES request payload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change, which allows users to pass arbitrary data into the bulk-chan, and then make use of it on the output channel.
An example use case is correlating input with successes and failures. In our use case the elasticsearch ID may not be sufficient for this so extra metadata is required
To add metadata, a user can add a map with a namespaced keyword:
:qbits.spandex/bulk-jobto the input channel, if this keyword exists, it is used as the payload, else the whole input is used as the payload (the current behaviour).