Skip to content

Commit 4d32988

Browse files
committed
Merge pull request #2438 from abstractive/celluloid-17
Resolve Celluloid 0.17.0 compatibility.
2 parents e4c58a2 + bc7c701 commit 4d32988

File tree

5 files changed

+7
-3
lines changed

5 files changed

+7
-3
lines changed

Changes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ HEAD
22
-----------
33

44
- Safer display of job data in Web UI [#2405]
5+
- Updated for compatibility with Celluloid `0.17.*`
56

67
3.4.1
78
-----------

lib/sidekiq/fetch.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def handle_fetch_exception(ex)
6666
@down ||= Time.now
6767
pause
6868
after(0) { fetch }
69-
rescue Task::TerminatedError
69+
rescue Celluloid::TaskTerminated
7070
# If redis is down when we try to shut down, all the fetch backlog
7171
# raises these errors. Haven't been able to figure out what I'm doing wrong.
7272
end

lib/sidekiq/scheduled.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def initial_wait
104104
# of workers), and 5 random seconds to ensure they don't all hit Redis at the same time.
105105
sleep(INITIAL_WAIT) unless Sidekiq.options[:poll_interval_average]
106106
sleep(5 * rand)
107-
rescue Celluloid::Task::TerminatedError
107+
rescue Celluloid::TaskTerminated
108108
# Hit Ctrl-C when Sidekiq is finished booting and we have a chance
109109
# to get here.
110110
end

myapp/Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ end
1111

1212
gem 'rails'
1313
gem 'sidekiq', :path => '..'
14-
gem 'pry-byebug'
14+
15+
#de Does not work with jruby or rbx:
16+
#de gem 'pry-byebug'
1517

1618
# sidekiq-web dependencies
1719
gem 'sinatra'

test/helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
require 'minitest/autorun'
2424
require 'minitest/pride'
2525

26+
require 'celluloid/current'
2627
require 'celluloid/test'
2728
Celluloid.boot
2829
require 'sidekiq'

0 commit comments

Comments
 (0)