Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

631 ("line is too long"): set column according to start #117

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 9, 2017

This changes the column for "line is too long" warnings to the start
of the too long text.

This changes the `column` for "line is too long" warnings to the start
of the too long text.
@mpeterv
Copy link
Owner

mpeterv commented Aug 9, 2017

I like this, if an editor plugin highlights warning ranges in code this should make it clear where an overly long line should have ended to pass the check. Thanks!

@mpeterv mpeterv merged commit cb8fdb7 into mpeterv:master Aug 9, 2017
@blueyed
Copy link
Contributor Author

blueyed commented Aug 9, 2017

@mpeterv
Exactly my use case: I've noticed this with the luacheck integration in Neomake, and thought it's best to fix it upstream (instead of adjusting it later based on the message).
Thanks for merging it, and this nice linter in the first place!

@blueyed blueyed deleted the 631-column-start branch August 9, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants